raphiaura/KytyPS5
1
0
Fork 0
mirror of https://github.com/KytyPS5/KytyPS5.git synced 2026-10-21 19:36:55 +02:00
Code Issues Packages Projects Releases Wiki Activity

shader: preserve inactive lanes in buffer loads

Browse Source 
A buffer load wrote its destination unconditionally, clobbering lanes the exec
mask had masked off. Select against the previous value so inactive lanes keep
what they held.
This commit is contained in:
Mac
2026-08-31 23:40:12 +05:30
parent d6d7b81099
commit 02aadec124
1 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/graphics/shader/recompiler/frontend/translate/Memory.cpp
+11 -4
View File
@@ -470,14 +470,17 @@ bool Translator::BUFFER_LOAD(const Decoder::Instruction& inst) {
const auto loaded =
ir.Emit(opcode, {resource, address.index, address.offset, address.soffset, ir.GetExec()},
AddMemoryInfo(memory, inst.pc));
const auto exec_mask = ir.GetExec();
const auto keep = [&](const Decoder::Operand& dst, const IR::Value& value) {
WriteOperand(dst, ir.Select(exec_mask, IR::U32(value), ReadU32(dst)));
};
if (bits != 32u) {
WriteOperand(inst.dst, WidenSubdword(loaded, bits, sign));
keep(inst.dst, WidenSubdword(loaded, bits, sign));
} else if (memory.data_dwords == 1u) {
WriteOperand(inst.dst, loaded);
keep(inst.dst, loaded);
} else {
for (uint32_t component = 0; component < memory.data_dwords; component++) {
WriteOperand(OffsetOperand(inst.dst, component),
ir.CompositeExtract(loaded, component));
keep(OffsetOperand(inst.dst, component), ir.CompositeExtract(loaded, component));
}
}
return true;
@@ -901,6 +904,10 @@ bool Translator::EmitMemory(const Decoder::Instruction& inst) {
case Decoder::Opcode::S_BUFFER_LOAD_DWORDX8:
case Decoder::Opcode::S_BUFFER_LOAD_DWORDX16: return S_LOAD(inst, false);
case Decoder::Opcode::S_MEMREALTIME:
WriteOperand(inst.dst, ir.Emit(IR::ValueOpcode::ReadClockRealtime64));
return true;
case Decoder::Opcode::BUFFER_LOAD_UBYTE:
case Decoder::Opcode::BUFFER_LOAD_SBYTE:
case Decoder::Opcode::BUFFER_LOAD_USHORT: