From 228cf3fbf45c476488c6b13953cf903f8f362816 Mon Sep 17 00:00:00 2001 From: Beru Date: Thu, 17 Sep 2026 08:30:47 +0200 Subject: [PATCH] Build the launcher on Qt below 6.6 and cap the reference-clock log (#653) * Fix launcher build on Qt versions below 6.6 QVulkanInstance::NoPortabilityDrivers is only available since Qt 6.6, so guard its use the same way as the Apple-specific case. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Stop logging every reference-clock copy CopyData of the clock counter runs on every GPU wait, so the handler wrote one line per wait: a single SpongeBob boot that never reaches a frame logs 1312 of them, and the count grows with run time. Keep the first 64 lines for diagnostics; the copy itself is unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Remove reference-clock logging comment --------- Co-authored-by: YuhiAida <21134775+YuhiAida@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: nmzik --- src/graphics/guest_gpu/graphicsRun.cpp | 8 ++++++-- src/launcher/src/configurationEditDialog.cpp | 2 +- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/src/graphics/guest_gpu/graphicsRun.cpp b/src/graphics/guest_gpu/graphicsRun.cpp index dcdc8a8c7..086d1e83d 100644 --- a/src/graphics/guest_gpu/graphicsRun.cpp +++ b/src/graphics/guest_gpu/graphicsRun.cpp @@ -386,8 +386,12 @@ void CommandProcessor::WriteReferenceClock(uint64_t dst_address, uint32_t num_by } const auto value = Sync::ReadReferenceClock(); std::memcpy(reinterpret_cast(dst_address), &value, num_bytes); - LOGF("\t copy_data reference clock: dst=0x%016" PRIx64 " value=0x%016" PRIx64 " size=%u\n", - dst_address, value, num_bytes); + static std::atomic clock_log_count {0}; + if (clock_log_count.fetch_add(1) < 64) { + LOGF("\t copy_data reference clock: dst=0x%016" PRIx64 " value=0x%016" PRIx64 + " size=%u\n", + dst_address, value, num_bytes); + } } void CommandProcessor::DmaData(uint8_t engine, uint8_t dst_sel, uint8_t dst_cache_policy, diff --git a/src/launcher/src/configurationEditDialog.cpp b/src/launcher/src/configurationEditDialog.cpp index f68dd3e38..32e38e311 100644 --- a/src/launcher/src/configurationEditDialog.cpp +++ b/src/launcher/src/configurationEditDialog.cpp @@ -213,7 +213,7 @@ void ConfigurationEditDialog::Init(const Configuration& info) { #endif QVulkanInstance instance; instance.setApiVersion(QVersionNumber(1, 3, 0)); -#if !defined(__APPLE__) +#if !defined(__APPLE__) && QT_VERSION >= QT_VERSION_CHECK(6, 6, 0) instance.setFlags(QVulkanInstance::NoPortabilityDrivers); #endif if (instance.create()) {