From b8ad1d8c4bbb38051eb4c957ec5dcc0e20a93094 Mon Sep 17 00:00:00 2001 From: Saadi Date: Sun, 20 Sep 2026 15:47:25 +0100 Subject: [PATCH] common: return real Win32 cache flags from GetCacheAccessType (#673) GetCacheAccessType returned the sys_file_cache_type_t enum values as CreateFileW flags: SYS_FILE_CACHE_SEQUENTIAL_SCAN (2) became FILE_ATTRIBUTE_HIDDEN and SYS_FILE_CACHE_AUTO (0) lost the normal attributes, and no FILE_FLAG_SEQUENTIAL_SCAN hint was ever applied. Return FILE_FLAG_SEQUENTIAL_SCAN / FILE_ATTRIBUTE_NORMAL instead, mirroring the POSIX fadvise handling on Linux. --- src/common/platform/sysWindowsFileIO.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/common/platform/sysWindowsFileIO.cpp b/src/common/platform/sysWindowsFileIO.cpp index bbdc73d4e..54fb202a1 100644 --- a/src/common/platform/sysWindowsFileIO.cpp +++ b/src/common/platform/sysWindowsFileIO.cpp @@ -57,10 +57,10 @@ static DWORD GetCacheAccessType(sys_file_cache_type_t t) { } if (t == SYS_FILE_CACHE_SEQUENTIAL_SCAN) { - return SYS_FILE_CACHE_SEQUENTIAL_SCAN; + return FILE_FLAG_SEQUENTIAL_SCAN; } - return SYS_FILE_CACHE_AUTO; + return FILE_ATTRIBUTE_NORMAL; } void SysFileRead(void* data, uint32_t size, sys_file_t& f, uint32_t* bytes_read) {