raphiaura/KytyPS5
1
0
Fork 0
mirror of https://github.com/KytyPS5/KytyPS5.git synced 2026-10-28 13:56:59 +01:00
Code Issues Packages Projects Releases Wiki Activity

graphics: pm4: accept trailing PM4 type-2 packets

Browse Source 
* A one-dword type-2 NOP is a valid packet tail. Parse it normally instead of aborting command-buffer dumps.

Signed-off-by: Claxten <claxten10@gmail.com>
This commit is contained in:
Claxten
2026-07-29 17:13:38 +02:00
committed by nmzik
parent bc436548a9
commit c1a5927036
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/graphics/guest_gpu/pm4.cpp
+3 -1
View File
@@ -110,7 +110,6 @@ void DumpPm4PacketStream(Common::File* file, uint32_t* cmd_buffer, uint32_t star
auto* cmd = cmd_buffer + start_dw; auto* cmd = cmd_buffer + start_dw;
auto dw = num_dw; auto dw = num_dw;
while (dw != 0) { while (dw != 0) {
EXIT_NOT_IMPLEMENTED(dw < 2);
EXIT_NOT_IMPLEMENTED(dw > num_dw); EXIT_NOT_IMPLEMENTED(dw > num_dw);
auto cmd_id = *cmd++; auto cmd_id = *cmd++;
@@ -120,6 +119,9 @@ void DumpPm4PacketStream(Common::File* file, uint32_t* cmd_buffer, uint32_t star
uint32_t len = 0; uint32_t len = 0;
const auto packet_type = static_cast<PacketType>(cmd_id >> 30u); const auto packet_type = static_cast<PacketType>(cmd_id >> 30u);
// Type-2 packets are header-only padding; every other packet type requires a body.
EXIT_NOT_IMPLEMENTED(dw < 2 && packet_type != PacketType::Type2);
switch (packet_type) { switch (packet_type) {
case PacketType::Type3: { case PacketType::Type3: {
const bool sh_gx = (cmd_id & 0x2u) == 0; const bool sh_gx = (cmd_id & 0x2u) == 0;