diff --git a/src/graphics/guest_gpu/command_processor/pm4Handlers.cpp b/src/graphics/guest_gpu/command_processor/pm4Handlers.cpp index 6e8569393..dae2687ed 100644 --- a/src/graphics/guest_gpu/command_processor/pm4Handlers.cpp +++ b/src/graphics/guest_gpu/command_processor/pm4Handlers.cpp @@ -2433,12 +2433,12 @@ KYTY_CP_OP_PARSER(CpOpIndirectShRegs) { auto value = indirect_buffer[1]; // Not sure if this is correct - if (raw_cmd_offset != cmd_offset) { - LOGF_COLOR(Log::Color::Red, - "\t temporary: normalized indirect SH register offset 0x%08" PRIx32 - " -> 0x%08" PRIx32 "\n", - raw_cmd_offset, cmd_offset); - } + // if (raw_cmd_offset != cmd_offset) { + // LOGF_COLOR(Log::Color::Red, + // "\t temporary: normalized indirect SH register offset 0x%08" PRIx32 + // " -> 0x%08" PRIx32 "\n", + // raw_cmd_offset, cmd_offset); + // } // Not sure if this is correct if (cmd_offset == Pm4::SH_NOP || raw_cmd_offset == 0xffffffffu) { @@ -2494,12 +2494,12 @@ KYTY_CP_OP_PARSER(CpOpIndirectUcRegs) { auto value = indirect_buffer[1]; // Not sure if this is correct - if (raw_cmd_offset != cmd_offset) { - LOGF_COLOR(Log::Color::Red, - "\t temporary: normalized indirect UC register offset 0x%08" PRIx32 - " -> 0x%08" PRIx32 "\n", - raw_cmd_offset, cmd_offset); - } + // if (raw_cmd_offset != cmd_offset) { + // LOGF_COLOR(Log::Color::Red, + // "\t temporary: normalized indirect UC register offset 0x%08" PRIx32 + // " -> 0x%08" PRIx32 "\n", + // raw_cmd_offset, cmd_offset); + // } if (HwUcTrySetFakeRegister(cmd_offset, value)) { continue; } @@ -2855,12 +2855,12 @@ KYTY_CP_OP_PARSER(CpOpSetUconfigReg) { cmd_offset = raw_cmd_offset & 0x0fffffffu; } - if (raw_cmd_offset != cmd_offset) { - LOGF_COLOR(Log::Color::Red, - "\t temporary: normalized UC register offset 0x%08" PRIx32 " -> 0x%08" PRIx32 - "\n", - raw_cmd_offset, cmd_offset); - } + // if (raw_cmd_offset != cmd_offset) { + // LOGF_COLOR(Log::Color::Red, + // "\t temporary: normalized UC register offset 0x%08" PRIx32 " -> 0x%08" PRIx32 + // "\n", + // raw_cmd_offset, cmd_offset); + // } if (HwUcTrySetFakeRegisterRange(cmd_offset, buffer + 1, KYTY_PM4_LEN(cmd_id) - 2u)) { return KYTY_PM4_LEN(cmd_id) - 1u; } diff --git a/src/graphics/host_gpu/renderer/debug.cpp b/src/graphics/host_gpu/renderer/debug.cpp index 701facdf8..ba4e80771 100644 --- a/src/graphics/host_gpu/renderer/debug.cpp +++ b/src/graphics/host_gpu/renderer/debug.cpp @@ -827,7 +827,12 @@ static void EqaaPrint(const char* func, const HW::EqaaControl& c) { c.static_anchor_associations ? "true" : "false"); } -static void EqaaCheck(const HW::EqaaControl& c) { +static void EqaaCheck(const HW::EqaaControl& c, const HW::AaConfig& cf) { + // The EQAA controls only take effect while multisampling is on, so a single-sample + // target leaves them inert and has nothing to warn about. + if (cf.msaa_num_samples == 0) { + return; + } if (c.max_anchor_samples != 0 || c.ps_iter_samples != 0 || c.mask_export_num_samples != 0 || c.alpha_to_mask_num_samples != 0 || c.high_quality_intersections || c.incoherent_eqaa_reads || c.interpolate_comp_z || c.static_anchor_associations) { @@ -1192,7 +1197,7 @@ void hw_check(const CommandBuffer& buffer) { log_phase("blend"); BcCheck(bc, bclr, cc); log_phase("eqaa"); - EqaaCheck(eqaa); + EqaaCheck(eqaa, ac); log_phase("aa"); AaCheck(aa, ac); log_phase("done");