* kernel: apply clang-format to pthread.cpp
Output of the repository's pre-commit clang-format hook (v22.1.3) on
this file; no code change.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* kernel: fix the macOS build of host thread naming
199d0a9d (#1106) names guest threads on the host with the two-argument
glibc pthread_setname_np(thread, name). KYTY_PLATFORM is
KYTY_PLATFORM_LINUX on macOS too, so the macOS job now fails with "no
matching function for call to 'pthread_setname_np'": Apple's version
takes only the name and renames the calling thread. This code already
runs on the new thread itself (it passes pthread_self()), so use the
one-argument form on Apple with Apple's 63-character limit and keep the
Linux call unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Remove formatting
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: nmzik <Nmzik@mail.ru>
PthreadCreate carries a guest thread name, but RunThread never handed it to
the host, so every guest thread showed up as the same generic host thread
name in core dumps, perf samples and htop.
Call pthread_setname_np() on Linux so host-side diagnostics can attribute
work to the guest thread that caused it.
Why: Thread-atexit registrations were discarded, leaving objects alive after their guest TLS storage was released.
What: Store registrations per host thread and run them in LIFO order before pthread keys and guest TLS are destroyed.
Why safe: Only callbacks registered on the exiting thread run, once, before existing teardown continues.
* macos: POSIX platform layer (host fault handler, virtual memory)
- hostException: Mach/POSIX signal-based host fault handler mirroring the
Windows vectored handler (SIGSEGV/SIGBUS/SIGILL), behind
'#elif defined(__APPLE__)'. Windows and Linux branches are untouched.
- sysLinuxVirtual: mach_vm_region-based is_mapped (no /proc/self/maps on
macOS), PTHREAD_MUTEX_NORMAL, and a MAP_FIXED carve-in-place allocator that
never leaves an unmapped hole for dyld/Rosetta/Metal to claim. All
__APPLE__-guarded; the original Linux allocator path is preserved verbatim.
- sysLinuxDbg/sysLinuxFileIO: libgen.h for basename(), and a POSIX
opendir/readdir implementation of SysFileGetDents (previously a stub).
* macos: guest kernel backing, threads, and POSIX libs
- memory/memoryAddressSpace: anonymous shm_open backing (macOS has no
memfd_create) and re-reserve-on-unmap so a guest MAP_FIXED remap never
destroys a host mapping (__APPLE__-guarded). Drops host <sys/mman.h> MAP_*
macros so the guest's constexpr MAP_* constants compile (no-op on Windows).
- pthread: undef the host PTHREAD_STACK_MIN macro; on non-Windows, pin the
stack-switch asm's guest rsp/rbp to callee-saved r14/r15 (the template
clobbers r12/r13); __APPLE__ no-op for the absent pthread_condattr_setclock.
The Windows stack-switch asm is byte-identical.
- network: define SOCKET/INVALID_SOCKET for the non-Windows paths (were
undefined at 20+ use sites), and rename the non-Windows kernel_clock_*
helpers to the CamelCase names the callers already use. Both repair the
shared non-Windows build. Integer reinterpret_cast -> static_cast.
* loader: pin stack-switch asm operands to callee-saved registers
RunEntry switches to the guest stack with an asm template that clobbers
r12/r13 before consuming its inputs. With plain "r" constraints the compiler
may place func/guest_rsp/guest_rbp into r12/r13, so 'callq *func' jumps
through the saved host rsp -- a latent miscompile on every platform that any
unrelated codegen change can trigger. Pin the inputs to rbx/r14/r15, which the
template never touches and the SysV callee preserves.
General correctness fix (not macOS-specific); the same fix is applied to
pthread RunOnGuestStack.
* macos: Vulkan/MoltenVK graphics enablement
- pageManager: GPU write-tracking via Mach VM queries + mprotect (mprotect
cannot report the previous protection, so the expected-old check is dropped),
thread id via pthread_mach_thread_np, 4 KB page-size check -- __APPLE__-guarded.
- shaders/renderDraw/vulkanWindow: MoltenVK lacks VK_EXT_color_write_enable,
VK_EXT_depth_clip_enable and depthBounds; fall back to static color-write
masks and default depth clipping, request VK_KHR_portability_subset, and
reuse the graphics queue for present when only one queue is exposed. Non-Apple
pipeline/extension setup is unchanged.
- window: optional borderless window (KYTY_BORDERLESS) to sidestep a Rosetta
NSException in macOS window chrome.
* graphics: macOS thread identity for region tracking
Region-ownership locks resolve the current thread via GetCurrentThreadId()
on Windows and EXIT elsewhere. Use the Mach thread port on macOS (nonzero
per-thread id; 0 stays the no-owner sentinel).
* macos: marshal AppKit window operations to the main thread
The present worker thread shows the window, updates its icon and title, and
recreates a lost Vulkan surface. AppKit traps with 'Must only be used from the
main thread' when these run off the main thread. Route them through a small
task queue drained by the SDL main loop (an SDL_USEREVENT wakes the loop when
it is blocked in SDL_WaitEvent). Title updates are fire-and-forget; showing
the window and surface recreation wait for completion.
Windows and Linux call the SDL functions directly, as before.
* build: ignore the _Build output directory
_Build is the conventional out-of-tree build location (only _Build/vscode-clang
was ignored); a stray git add could sweep build artifacts into a commit.
* macos: isolate stack-switch workaround
---------
Co-authored-by: nmzik <Nmzik@mail.ru>
Nawid3333